]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i3c: dw: use parity8 helper instead of open coding it
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 7 Jan 2025 09:02:01 +0000 (10:02 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 12 Jan 2025 22:55:50 +0000 (23:55 +0100)
The kernel has now a generic helper for getting parity with easier to
understand semantics. Make use of it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20250107090204.6593-4-wsa+renesas@sang-engineering.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/dw-i3c-master.c

index f1c564b4801ed7c99d143228f7b3fc310a74ff11..d09ea5b6467ce915e19e261f735b72e3cc5e6066 100644 (file)
@@ -251,14 +251,6 @@ struct dw_i3c_i2c_dev_data {
        struct i3c_generic_ibi_pool *ibi_pool;
 };
 
-static u8 even_parity(u8 p)
-{
-       p ^= p >> 4;
-       p &= 0xf;
-
-       return (0x9669 >> p) & 1;
-}
-
 static bool dw_i3c_master_supports_ccc_cmd(struct i3c_master_controller *m,
                                           const struct i3c_ccc_cmd *cmd)
 {
@@ -848,7 +840,7 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
        struct dw_i3c_xfer *xfer;
        struct dw_i3c_cmd *cmd;
        u32 olddevs, newdevs;
-       u8 p, last_addr = 0;
+       u8 last_addr = 0;
        int ret, pos;
 
        ret = pm_runtime_resume_and_get(master->dev);
@@ -873,9 +865,9 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
                }
 
                master->devs[pos].addr = ret;
-               p = even_parity(ret);
                last_addr = ret;
-               ret |= (p << 7);
+
+               ret |= parity8(ret) ? 0 : BIT(7);
 
                writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(ret),
                       master->regs +