]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: ethtool: tsconfig: set command must provide a reply
authorVadim Fedorenko <vadfed@meta.com>
Mon, 22 Sep 2025 23:19:24 +0000 (16:19 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 24 Sep 2025 00:13:05 +0000 (17:13 -0700)
Timestamping configuration through ethtool has inconsistent behavior of
skipping the reply for set command if configuration was not changed. Fix
it be providing reply in any case.

Fixes: 6e9e2eed4f39d ("net: ethtool: Add support for tsconfig command to get/set hwtstamp config")
Signed-off-by: Vadim Fedorenko <vadfed@meta.com>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Link: https://patch.msgid.link/20250922231924.2769571-1-vadfed@meta.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/tsconfig.c

index 2be356bdfe8737fe2a37eecb1ff1cfdaee30df67..169b413b31fc5ff2c541ca96c40beaf71dc5a39f 100644 (file)
@@ -423,13 +423,11 @@ static int ethnl_set_tsconfig(struct ethnl_req_info *req_base,
                        return ret;
        }
 
-       if (hwprov_mod || config_mod) {
-               ret = tsconfig_send_reply(dev, info);
-               if (ret && ret != -EOPNOTSUPP) {
-                       NL_SET_ERR_MSG(info->extack,
-                                      "error while reading the new configuration set");
-                       return ret;
-               }
+       ret = tsconfig_send_reply(dev, info);
+       if (ret && ret != -EOPNOTSUPP) {
+               NL_SET_ERR_MSG(info->extack,
+                              "error while reading the new configuration set");
+               return ret;
        }
 
        /* tsconfig has no notification */