re PR c++/45588 (unused-but-set-variable false trigger building gold)

	PR c++/45588
	* pt.c (tsubst) <case INTEGER_TYPE>: Call mark_rvalue_use
	before calling fold_decl_constant_value.

	* g++.dg/warn/Wunused-var-15.C: New test.

From-SVN: r164051

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index d4171b0fc0286b6f84c7a8be32c60f0bec088d69..f2c7faa06259d7fe316d3100a1a8818ff45d9ad8 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2010-09-08  Jakub Jelinek  <jakub@redhat.com>
+
+       PR c++/45588
+       * pt.c (tsubst) <case INTEGER_TYPE>: Call mark_rvalue_use
+       before calling fold_decl_constant_value.
+
 2010-09-07  Arnaud Charlet  <charlet@adacore.com>
 
        * cp-tree.h (build_enumerator): Add new location_t parameter.

diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c
index 75a9d1b25a41e34d02a252b6e276433ae59cd731..5c324847268c5effb064f31a48bd1b608b51346e 100644 (file)
--- a/gcc/cp/pt.c
+++ b/gcc/cp/pt.c
@@ -10116,6 +10116,7 @@ tsubst (tree t, tree args, tsubst_flags_t complain, tree in_decl)
            && !TREE_TYPE (max))
          TREE_TYPE (max) = TREE_TYPE (TREE_OPERAND (max, 0));
 
+       max = mark_rvalue_use (max);
        max = fold_decl_constant_value (max);
 
        /* If we're in a partial instantiation, preserve the magic NOP_EXPR

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index c18b432333e0d36d36497d44b3cb4b1197bc07a6..1ad764c60b374cc3a15669499225babf7fdd3a9d 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2010-09-08  Jakub Jelinek  <jakub@redhat.com>
+
+       PR c++/45588
+       * g++.dg/warn/Wunused-var-15.C: New test.
+
 2010-09-08  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>
 
        * c-c++-common/Wunused-var-12.c: Add -fno-common to options on 32-bit

diff --git a/gcc/testsuite/g++.dg/warn/Wunused-var-15.C b/gcc/testsuite/g++.dg/warn/Wunused-var-15.C
new file mode 100644 (file)
index 0000000..9782ccb
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Wunused-var-15.C
@@ -0,0 +1,29 @@
+// PR c++/45588
+// { dg-do compile }
+// { dg-options "-Wunused" }
+
+void bar (unsigned char *);
+
+template <int N>
+struct S
+{
+  static const int k = 6;
+};
+
+template <int N>
+const int S<N>::k;
+
+template <int N>
+void
+foo ()
+{
+  const int i = S<N>::k;
+  unsigned char a[i];
+  bar (a);
+}
+
+void
+baz ()
+{
+  foo<0> ();
+}