]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
conf/ile: avoid atoi() in config_no_new_privs()
authorChristian Brauner <christian.brauner@canonical.com>
Fri, 28 Oct 2016 18:26:51 +0000 (20:26 +0200)
committerChristian Brauner <christian.brauner@canonical.com>
Tue, 22 Nov 2016 03:45:58 +0000 (04:45 +0100)
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
src/lxc/confile.c

index eccdcb54ca6d661bf0ed8f0787e20f68f7f860f5..756b1ec61ab9ea561a53ddbaea6c17212d0c190a 100644 (file)
@@ -2992,12 +2992,16 @@ static int config_syslog(const char *key, const char *value,
 static int config_no_new_privs(const char *key, const char *value,
                                    struct lxc_conf *lxc_conf)
 {
-       int v = atoi(value);
+       unsigned int v;
 
-       if (v != 0 && v != 1) {
+       if (lxc_safe_uint(value, &v) < 0)
+               return -1;
+
+       if (v > 1) {
                ERROR("Wrong value for lxc.no_new_privs. Can only be set to 0 or 1");
                return -1;
        }
+
        lxc_conf->no_new_privs = v ? true : false;
 
        return 0;