]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: plda: Silence 'set affinity failed' warning
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Tue, 23 Jul 2024 13:27:09 +0000 (15:27 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 29 Jul 2024 17:46:35 +0000 (12:46 -0500)
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows
migrate_one_irq() to exit right away, without warnings like this:

  IRQ...: set affinity failed(-22)

Remove the .irq_set_affinity() implementation that is no longer needed.

Link: https://lore.kernel.org/r/20240723132958.41320-10-marek.vasut+renesas@mailbox.org
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
drivers/pci/controller/plda/pcie-plda-host.c

index a18923d7cea6e73c26644f61b43076e8e847eeab..8533dc618d45f0bc0673579fe1fb8535693a8fa0 100644 (file)
@@ -76,17 +76,10 @@ static void plda_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
                (int)data->hwirq, msg->address_hi, msg->address_lo);
 }
 
-static int plda_msi_set_affinity(struct irq_data *irq_data,
-                                const struct cpumask *mask, bool force)
-{
-       return -EINVAL;
-}
-
 static struct irq_chip plda_msi_bottom_irq_chip = {
        .name = "PLDA MSI",
        .irq_ack = plda_msi_bottom_irq_ack,
        .irq_compose_msi_msg = plda_compose_msi_msg,
-       .irq_set_affinity = plda_msi_set_affinity,
 };
 
 static int plda_irq_msi_domain_alloc(struct irq_domain *domain,
@@ -146,8 +139,8 @@ static struct irq_chip plda_msi_irq_chip = {
 };
 
 static struct msi_domain_info plda_msi_domain_info = {
-       .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
-                 MSI_FLAG_PCI_MSIX),
+       .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
+                MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
        .chip = &plda_msi_irq_chip,
 };