]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virsh: Annotate rest of _ARGV arguments as positional
authorPeter Krempa <pkrempa@redhat.com>
Wed, 13 Mar 2024 21:45:04 +0000 (22:45 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 2 Apr 2024 12:24:29 +0000 (14:24 +0200)
In most cases it's the usual/recommended way to use those commands:

 $ virsh qemu-monitor-command VMNAME cmd args args args

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tools/virsh-domain.c
tools/virsh-network.c

index 0bf4d524b0f7e1768e6a612a5c3ad723ca304535..801b01bb426530419987d660bd56caa6d3b02fe6 100644 (file)
@@ -5000,6 +5000,7 @@ static const vshCmdOptDef opts_schedinfo[] = {
     VIRSH_COMMON_OPT_LIVE(N_("get/set value from running domain")),
     {.name = "set",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .flags = VSH_OFLAG_NONE,
      .help = N_("parameter=value")
     },
@@ -8188,6 +8189,7 @@ static const vshCmdOptDef opts_desc[] = {
     },
     {.name = "new-desc",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .help = N_("message")
     },
     {.name = NULL}
@@ -8493,6 +8495,7 @@ static const vshCmdOptDef opts_send_key[] = {
     {.name = "keycode",
      .type = VSH_OT_ARGV,
      .required = true,
+     .positional = true,
      .completer = virshKeycodeNameCompleter,
      .help = N_("the key code")
     },
@@ -9600,6 +9603,7 @@ static const vshCmdOptDef opts_qemu_monitor_command[] = {
     },
     {.name = "cmd",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .required = true,
      .help = N_("command")
     },
@@ -9996,6 +10000,7 @@ static const vshCmdOptDef opts_qemu_agent_command[] = {
     },
     {.name = "cmd",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .required = true,
      .help = N_("command")
     },
@@ -10092,6 +10097,7 @@ static const vshCmdOptDef opts_lxc_enter_namespace[] = {
     },
     {.name = "cmd",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .required = true,
      .help = N_("command to run")
     },
@@ -12795,6 +12801,7 @@ static const vshCmdOptDef opts_domfsfreeze[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE),
     {.name = "mountpoint",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .completer = virshDomainFSMountpointsCompleter,
      .help = N_("mountpoint path to be frozen")
     },
@@ -12835,6 +12842,7 @@ static const vshCmdOptDef opts_domfsthaw[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE),
     {.name = "mountpoint",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .completer = virshDomainFSMountpointsCompleter,
      .help = N_("mountpoint path to be thawed")
     },
index 240d10eea78ea00e431f50a8dbf28f8f8d866dc2..59ca842181d47029cafbf43822b53c031765c792 100644 (file)
@@ -324,6 +324,7 @@ static const vshCmdOptDef opts_network_desc[] = {
     },
     {.name = "new-desc",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .help = N_("message")
     },
     {.name = NULL}