]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mptcp: select CRYPTO_LIB_UTILS instead of CRYPTO
authorEric Biggers <ebiggers@kernel.org>
Thu, 4 Dec 2025 05:44:17 +0000 (21:44 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Dec 2025 07:44:16 +0000 (23:44 -0800)
Since the only crypto functions used by the mptcp code are the SHA-256
library functions and crypto_memneq(), select only the options needed
for those: CRYPTO_LIB_SHA256 and CRYPTO_LIB_UTILS.

Previously, CRYPTO was selected instead of CRYPTO_LIB_UTILS.  That does
pull in CRYPTO_LIB_UTILS as well, but it's unnecessarily broad.

Years ago, the CRYPTO_LIB_* options were visible only when CRYPTO.  That
may be another reason why CRYPTO is selected here.  However, that was
fixed years ago, and the libraries can now be selected directly.

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Link: https://patch.msgid.link/20251204054417.491439-1-ebiggers@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/Kconfig

index 20328920f6ed17e632340c065d46ec915ec5510a..be71fc9b4638145f76fbec6094f427c89056d6ec 100644 (file)
@@ -4,7 +4,7 @@ config MPTCP
        depends on INET
        select SKB_EXTENSIONS
        select CRYPTO_LIB_SHA256
-       select CRYPTO
+       select CRYPTO_LIB_UTILS
        help
          Multipath TCP (MPTCP) connections send and receive data over multiple
          subflows in order to utilize multiple network paths. Each subflow