]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli: Avoid a ZERO_STRUCT with a direct initialization
authorVolker Lendecke <vl@samba.org>
Tue, 10 Jun 2025 07:55:58 +0000 (09:55 +0200)
committerMartin Schwenke <martins@samba.org>
Sat, 14 Jun 2025 08:46:34 +0000 (08:46 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
libcli/smb/smbXcli_base.c

index d1e36a3fa1eed62feb81b476ab7a4e1630274f91..bf0ffb83702b03111552dea3c75676cb5d48ea1d 100644 (file)
@@ -4485,7 +4485,7 @@ static void smbXcli_negprot_smb1_done(struct tevent_req *subreq)
        bool server_writeunlock = false;
        struct GUID server_guid = GUID_zero();
        DATA_BLOB server_gss_blob = data_blob_null;
-       uint8_t server_challenge[8];
+       uint8_t server_challenge[8] = {};
        char *server_workgroup = NULL;
        char *server_name = NULL;
        int server_time_zone = 0;
@@ -4505,8 +4505,6 @@ static void smbXcli_negprot_smb1_done(struct tevent_req *subreq)
        }
        };
 
-       ZERO_STRUCT(server_challenge);
-
        status = smb1cli_req_recv(subreq, state,
                                  &recv_iov,
                                  &inhdr,