Avoid a segfault when calling src-verify without any arguments.

FossilOrigin-Name: c0c4e6f111b9b16538aad33e83f02f8d7835e952649f5cee610c068722bea4a4

diff --git a/manifest b/manifest
index 60d7c02ac19977616113cff5c864b7f385e990e4..7256758673f0a30ca4987e40bb049287d4fe570f 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Add\stwo\smissing\s$(BEXE)\ssuffixes,\sas\sreported\sin\s[forum:9ad28680d394afda\s|\sforum\spost\s9ad28680d3].\sProblem\sintroduced\sby\s[1218a203483cecdc]\sbeing\sincomplete\sin\swhere\sit\sadded\sthat\ssuffix.
-D 2024-10-11T19:18:44.588
+C Avoid\sa\ssegfault\swhen\scalling\ssrc-verify\swithout\sany\sarguments.
+D 2024-10-11T19:22:32.233
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -2181,7 +2181,7 @@ F tool/sqlite3-rsync.c 7c78ba15afa0b929604adb91c94af8dbdf8cbe87be8a5cba5353af0e3
 F tool/sqlite3_analyzer.c.in 348ba349bbdc93c9866439f9f935d7284866a2a4e6898bc906ae1204ade56918
 F tool/sqltclsh.c.in 1bcc2e9da58fadf17b0bf6a50e68c1159e602ce057210b655d50bad5aaaef898
 F tool/sqltclsh.tcl 862f4cf1418df5e1315b5db3b5ebe88969e2a784525af5fbf9596592f14ed848
-F tool/src-verify.c 41c586dee84d0b190ad13e0282ed83d4a65ec9fefde9adf4943efdf6558eea7f
+F tool/src-verify.c d00f93263aa2fa6ba0cba0106d95458e6effb94fdb5fc634f56834f90c05bbb4
 F tool/srcck1.c 371de5363b70154012955544f86fdee8f6e5326f
 F tool/srctree-check.tcl c15f860a3c97d5f7b4c14b60392d9466af29dd006c4ef18127f502641e2977a8
 F tool/stack_usage.tcl f8e71b92cdb099a147dad572375595eae55eca43
@@ -2216,8 +2216,8 @@ F vsixtest/vsixtest.tcl 6195aba1f12a5e10efc2b8c0009532167be5e301abe5b31385638080
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P bf996f710212fbc0c0c67789e3f6f1a805e7b81e0265b312265ca7286e76d6f3
-R c1596485fe08faef2532f3355a796371
+P de9663c0aae92e457ddda48b751b32f205bfab29f60b055571e5f69b41ffd584
+R 9bd2bb9818dfd0677d48239709bdf115
 U stephan
-Z c9b6b67c140ab2544242449edb704a7d
+Z cd2bcf638ae2cec928818c120f6c2ee2
 # Remove this line to create a well-formed Fossil manifest.

diff --git a/manifest.uuid b/manifest.uuid
index 84d2d4ef9a77dc49bcb3f4f7b99970b5727f1117..18a34670b78e1b4bc2fa99514bc85fe0d2bedb18 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-de9663c0aae92e457ddda48b751b32f205bfab29f60b055571e5f69b41ffd584
+c0c4e6f111b9b16538aad33e83f02f8d7835e952649f5cee610c068722bea4a4

diff --git a/tool/src-verify.c b/tool/src-verify.c
index 762904656417f16f303191c9cf38ee91425820d5..0c7ed6f4c4322550c8eba7cac0f783a72cdf1897 100644 (file)
--- a/tool/src-verify.c
+++ b/tool/src-verify.c
@@ -854,12 +854,16 @@ int main(int argc, char **argv){
       xErr = errorMsgNH;
       continue;
     }
+  usage:
     fprintf(stderr, "Usage: %s DIRECTORY\n"
                     "   or: %s --sha1 FILE ...\n"
                     "   or: %s --sha3 FILE ...\n",
       argv[0], argv[0], argv[0]);
     return 1;
   }
+  if( !zDir ){
+    goto usage;
+  }
   if( strlen(zDir)>1000 ){
     fprintf(stderr, "Directory argument too big: [%s]\n", zDir);
     return 1;