]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
maple_tree: fix mt_destroy_walk() on root leaf node
authorWei Yang <richard.weiyang@gmail.com>
Tue, 24 Jun 2025 19:18:40 +0000 (15:18 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 10 Jul 2025 04:07:52 +0000 (21:07 -0700)
On destroy, we should set each node dead.  But current code miss this when
the maple tree has only the root node.

The reason is mt_destroy_walk() leverage mte_destroy_descend() to set node
dead, but this is skipped since the only root node is a leaf.

Fixes this by setting the node dead if it is a leaf.

Link: https://lore.kernel.org/all/20250407231354.11771-1-richard.weiyang@gmail.com/
Link: https://lkml.kernel.org/r/20250624191841.64682-1-Liam.Howlett@oracle.com
Fixes: 54a611b60590 ("Maple Tree: add new data structure")
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Reviewed-by: Dev Jain <dev.jain@arm.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/maple_tree.c

index 00524e55a21e05472c181a3abebb79fcb7c6b476..ef66be963798eeaf20774e47203880bdbe840044 100644 (file)
@@ -5319,6 +5319,7 @@ static void mt_destroy_walk(struct maple_enode *enode, struct maple_tree *mt,
        struct maple_enode *start;
 
        if (mte_is_leaf(enode)) {
+               mte_set_node_dead(enode);
                node->type = mte_node_type(enode);
                goto free_leaf;
        }