]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/shmem-helper: Remove obsoleted is_iomem test
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Sat, 22 Mar 2025 21:26:04 +0000 (00:26 +0300)
committerDmitry Osipenko <dmitry.osipenko@collabora.com>
Wed, 26 Mar 2025 20:00:14 +0000 (23:00 +0300)
Everything that uses the mapped buffer should be agnostic to is_iomem.
The only reason for the is_iomem test is that we're setting shmem->vaddr
to the returned map->vaddr. Now that the shmem->vaddr code is gone, remove
the obsoleted is_iomem test to clean up the code.

Acked-by: Maxime Ripard <mripard@kernel.org>
Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.d>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250322212608.40511-7-dmitry.osipenko@collabora.com
drivers/gpu/drm/drm_gem_shmem_helper.c

index a9e35a46e72b9fd7d8b5d55242ec085ab86bcb78..277e792a0c5c6987ed51c9ebea969a8115aca518 100644 (file)
@@ -340,12 +340,6 @@ int drm_gem_shmem_vmap_locked(struct drm_gem_shmem_object *shmem,
 
        if (drm_gem_is_imported(obj)) {
                ret = dma_buf_vmap(obj->dma_buf, map);
-               if (!ret) {
-                       if (drm_WARN_ON(obj->dev, map->is_iomem)) {
-                               dma_buf_vunmap(obj->dma_buf, map);
-                               return -EIO;
-                       }
-               }
        } else {
                pgprot_t prot = PAGE_KERNEL;