net: stmmac: imx: use ->set_phy_intf_sel()

Rather than placing the phy_intf_sel() setup in the ->init() method,
move it to the new ->set_phy_intf_sel() method.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vFt5C-0000000ChpR-2kAB@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
index ae1b73e1bcb2fcf611a3ffd4c554b45b3b95f3cc..db288fbd5a4df9db4a6e216695df34b6c1c4e890 100644 (file)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
@@ -134,36 +134,19 @@ static int imx_dwmac_clks_config(void *priv, bool enabled)
        return ret;
 }
 
-static int imx_dwmac_init(struct platform_device *pdev, void *priv)
+static int imx_set_phy_intf_sel(void *bsp_priv, u8 phy_intf_sel)
 {
-       struct imx_priv_data *dwmac = priv;
-       phy_interface_t interface;
-       int phy_intf_sel, ret;
-
-       if (dwmac->ops->set_intf_mode) {
-               interface = dwmac->plat_dat->phy_interface;
-
-               phy_intf_sel = stmmac_get_phy_intf_sel(interface);
-               if (phy_intf_sel != PHY_INTF_SEL_GMII_MII &&
-                   phy_intf_sel != PHY_INTF_SEL_RGMII &&
-                   phy_intf_sel != PHY_INTF_SEL_RMII) {
-                       dev_dbg(dwmac->dev,
-                               "imx dwmac doesn't support %s interface\n",
-                               phy_modes(interface));
-                       return phy_intf_sel < 0 ? phy_intf_sel : -EINVAL;
-               }
+       struct imx_priv_data *dwmac = bsp_priv;
 
-               ret = dwmac->ops->set_intf_mode(dwmac, phy_intf_sel);
-               if (ret)
-                       return ret;
-       }
+       if (!dwmac->ops->set_intf_mode)
+               return 0;
 
-       return 0;
-}
+       if (phy_intf_sel != PHY_INTF_SEL_GMII_MII &&
+           phy_intf_sel != PHY_INTF_SEL_RGMII &&
+           phy_intf_sel != PHY_INTF_SEL_RMII)
+               return -EINVAL;
 
-static void imx_dwmac_exit(struct platform_device *pdev, void *priv)
-{
-       /* nothing to do now */
+       return dwmac->ops->set_intf_mode(dwmac, phy_intf_sel);
 }
 
 static int imx_dwmac_set_clk_tx_rate(void *bsp_priv, struct clk *clk_tx_i,
@@ -342,8 +325,7 @@ static int imx_dwmac_probe(struct platform_device *pdev)
                plat_dat->tx_queues_cfg[i].tbs_en = 1;
 
        plat_dat->host_dma_width = dwmac->ops->addr_width;
-       plat_dat->init = imx_dwmac_init;
-       plat_dat->exit = imx_dwmac_exit;
+       plat_dat->set_phy_intf_sel = imx_set_phy_intf_sel;
        plat_dat->clks_config = imx_dwmac_clks_config;
        plat_dat->bsp_priv = dwmac;
        dwmac->plat_dat = plat_dat;