Change default maildisplayname to be RFC5322-compliant.

This will change the "From" header of emails sent by fcron.

diff --git a/configure.in b/configure.in
index 9783367a7bc2366fee73ca4f67ebcc942413dcec..84844d657dbe7282db075cd9668d287f3bd1e9a2 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -180,7 +180,9 @@ AC_ARG_ENABLE(checks,
   esac
 ])
 
-MAILDISPLAYNAME=""
+dnl Set a non-empty value to use a RFC5322-compliant "From" email header,
+dnl or set to empty string to keep the previous non RFC5322-compliant one.
+MAILDISPLAYNAME="Fcron Daemon"
 AC_MSG_CHECKING([mail display name])
 AC_MSG_RESULT([$MAILDISPLAYNAME])
 AC_SUBST([MAILDISPLAYNAME])

diff --git a/doc/en/fcron.conf.5.sgml b/doc/en/fcron.conf.5.sgml
index ebfacb3c0e18333c396f3e39cd2471893e6fefa7..726ca73693327b725d0a64b4f471047fcacc2f1a 100644 (file)
--- a/doc/en/fcron.conf.5.sgml
+++ b/doc/en/fcron.conf.5.sgml
@@ -160,14 +160,12 @@ A copy of the license is included in gfdl.sgml.
                                        <listitem>
                                                <para>
                                                        Display name for the "From: " header of mails sent
-                                                       by us. N.B. &fcron has been following Vixie cron's
+                                                       by us. Note that in the past, &fcron was following Vixie cron's
                                                        default email header format which is not fully
                                                        compliant with RFC 5322 (see <ulink
                                                        url="https://github.com/yo8192/fcron/issues/15">Issue
-                                                       #15 </ulink>).  During this transition phase, to
-                                                       achieve full RFC compliance, you may set a display
-                                                       name. Leaving it empty will preserve the old
-                                                       behavior.
+                                                       #15 </ulink>). fcron will revert to this old behaviour when
+                                                       this option is set to an empty string.
                                                </para>
                                        </listitem>
                                </varlistentry>

diff --git a/files/fcron.conf.in b/files/fcron.conf.in
index 68b0935462d4fb0418a66b1047294c18b9b6b465..a0bfd5cfbcb326a98f244b50eada28c112eaf0c3 100644 (file)
--- a/files/fcron.conf.in
+++ b/files/fcron.conf.in
@@ -24,12 +24,10 @@ sendmail    =       @@SENDMAIL@
 # Location of the default editor for "fcrontab -e"
 editor         =       @@FCRON_EDITOR@
 
-# Display name for the "From: " header of mails sent by us. Default is
-# unset/empty, which keeps the "From: " header as it was before this feature
-# was added -- not RFC5322-compliant, though.
-# The default will soon be the sane RFC5322-compliant:
-#
-#   maildisplayname = Fcron Daemon
+# Display name for the "From: " header of emails sent by fcron.
+# Set to a non-empty string to make fcron use a RFC5322-compliant "From",
+# or to an empty string to keep the "From" header to the non-RFC5322-compliant
+# value we had before this feature was added.
 #
 # Please read fcron.conf(5) before setting it!
 maildisplayname        =       @@MAILDISPLAYNAME@