]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tcp: do not clear packets_out in tcp_create_openreq_child()
authorEric Dumazet <edumazet@google.com>
Thu, 17 Jan 2019 19:23:34 +0000 (11:23 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Jan 2019 06:19:04 +0000 (22:19 -0800)
New sockets have this field cleared, and tcp_disconnect()
calls tcp_write_queue_purge() which among other things
also clear tp->packets_out

So a listener is guaranteed to have this field cleared.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_minisocks.c

index 9799f1d32e44f4c733b41c4d8fc7739970ccca28..830e4eb558f8861fb3813c35b215425a53cacf62 100644 (file)
@@ -484,7 +484,6 @@ struct sock *tcp_create_openreq_child(const struct sock *sk,
        minmax_reset(&newtp->rtt_min, tcp_jiffies32, ~0U);
        newicsk->icsk_ack.lrcvtime = tcp_jiffies32;
 
-       newtp->packets_out = 0;
        newtp->retrans_out = 0;
        newtp->sacked_out = 0;
        newtp->tlp_high_seq = 0;