]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/imagination: Use pvr_vm_context_get()
authorMatt Coster <Matt.Coster@imgtec.com>
Fri, 30 Aug 2024 15:06:01 +0000 (15:06 +0000)
committerMatt Coster <matt.coster@imgtec.com>
Mon, 2 Sep 2024 08:42:45 +0000 (09:42 +0100)
I missed this open-coded kref_get() while trying to debug a refcount
bug, so let's use the helper function here to avoid that waste of time
again in the future.

Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code")
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Link: https://patchwork.freedesktop.org/patch/msgid/8616641d-6005-4b25-bc0a-0b53985a0e08@imgtec.com
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
drivers/gpu/drm/imagination/pvr_vm.c

index e59517ba039efdafc3f41fa1a39f65349588a367..ffd466509d0b51221696d7d97ca1f3e76a1b9f34 100644 (file)
@@ -636,9 +636,7 @@ pvr_vm_context_lookup(struct pvr_file *pvr_file, u32 handle)
 
        xa_lock(&pvr_file->vm_ctx_handles);
        vm_ctx = xa_load(&pvr_file->vm_ctx_handles, handle);
-       if (vm_ctx)
-               kref_get(&vm_ctx->ref_count);
-
+       pvr_vm_context_get(vm_ctx);
        xa_unlock(&pvr_file->vm_ctx_handles);
 
        return vm_ctx;