bcachefs: Fix __bch2_fsck_err() warning

We only warn about having a btree_trans that wasn't passed in if we'll
be prompting.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/error.c b/fs/bcachefs/error.c
index 7a79f695ba2e749bbcb352864028c8ff9f51736f..b679def8fb98c7c94b70bb18b43b1b1600df1f4d 100644 (file)
--- a/fs/bcachefs/error.c
+++ b/fs/bcachefs/error.c
@@ -251,7 +251,10 @@ int __bch2_fsck_err(struct bch_fs *c,
         *   delete the key)
         * - and we don't need to warn if we're not prompting
         */
-       WARN_ON(!(flags & FSCK_AUTOFIX) && !trans && bch2_current_has_btree_trans(c));
+       WARN_ON((flags & FSCK_CAN_FIX) &&
+               !(flags & FSCK_AUTOFIX) &&
+               !trans &&
+               bch2_current_has_btree_trans(c));
 
        if ((flags & FSCK_CAN_FIX) &&
            test_bit(err, c->sb.errors_silent))