]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
login-common: Remove '?' in the beginning of login_source_ips functionality.
authorsergey.kitov <sergey.kitov@open-xchange.com>
Fri, 20 Oct 2023 08:20:22 +0000 (11:20 +0300)
committerAki Tuomi <aki.tuomi@open-xchange.com>
Fri, 17 Jan 2025 08:39:59 +0000 (10:39 +0200)
This was never very useful feature, and it makes it more difficult to convert the setting to boollist.

src/login-common/main.c

index b87e877d4db4a3b73a3b7b67b2b4100121afbab4..c2d558c4df7b2f9e7311d45589edbb749c13d2e5 100644 (file)
@@ -279,17 +279,9 @@ parse_login_source_ips(const char *ips_str)
 {
        const char *const *tmp;
        struct ip_addr *tmp_ips;
-       bool skip_nonworking = FALSE;
        unsigned int i, tmp_ips_count;
        int ret;
 
-       if (ips_str[0] == '?') {
-               /* try binding to the IP immediately. if it doesn't
-                  work, skip it. (this allows using the same config file for
-                  all the servers.) */
-               skip_nonworking = TRUE;
-               ips_str++;
-       }
        i_array_init(&login_source_v4_ips_array, 4);
        i_array_init(&login_source_v6_ips_array, 4);
 
@@ -301,8 +293,6 @@ parse_login_source_ips(const char *ips_str)
                        continue;
                }
                for (i = 0; i < tmp_ips_count; i++) {
-                       if (skip_nonworking && net_try_bind(&tmp_ips[i]) < 0)
-                               continue;
                        if (tmp_ips[i].family == AF_INET)
                                array_push_back(&login_source_v4_ips_array, &tmp_ips[i]);
                        else if (tmp_ips[i].family == AF_INET6)