]> git.ipfire.org Git - thirdparty/collectd.git/commitdiff
processes plugin: Return boolean from `process_resource()`.
authorFlorian Forster <octo@collectd.org>
Sat, 24 Feb 2024 21:31:52 +0000 (22:31 +0100)
committerFlorian Forster <octo@collectd.org>
Sat, 24 Feb 2024 22:21:29 +0000 (23:21 +0100)
src/processes.c

index 8ec61aa1c2c5facb29ac491153a7815f1943caa0..84d8988c40234d008d7439720b68837d3d3c86d3 100644 (file)
@@ -864,8 +864,8 @@ static int ps_init(void) {
   return 0;
 } /* int ps_init */
 
-static int process_resource(procstat_t const *ps, procstat_entry_t const *pse,
-                            label_set_t *ret_resource) {
+static bool process_resource(procstat_t const *ps, procstat_entry_t const *pse,
+                             label_set_t *ret_resource) {
   bool have_id = false;
 
 #if HAVE_REGEX_H
@@ -893,7 +893,7 @@ static int process_resource(procstat_t const *ps, procstat_entry_t const *pse,
     have_id = true;
   }
 
-  return have_id ? 0 : -1;
+  return have_id;
 }
 
 static void ps_dispatch_cpu(label_set_t resource, procstat_entry_t const *pse) {
@@ -976,9 +976,10 @@ static void ps_dispatch_delay(label_set_t resource,
 static void ps_dispatch_procstat_entry(procstat_t const *ps,
                                        procstat_entry_t const *pse) {
   label_set_t resource = {0};
-  int status = process_resource(ps, pse, &resource);
-  if (status != 0) {
+  bool ok = process_resource(ps, pse, &resource);
+  if (!ok) {
     ERROR("processes plugin: Creating resource attributes failed.");
+    return;
   } else {
     strbuf_t buf = STRBUF_CREATE;
     label_set_format(&buf, resource);