4.14-stable patches

added patches:
	ftrace-avoid-potential-division-by-zero-in-function-profiler.patch

diff --git a/queue-4.14/ftrace-avoid-potential-division-by-zero-in-function-profiler.patch b/queue-4.14/ftrace-avoid-potential-division-by-zero-in-function-profiler.patch
new file mode 100644 (file)
index 0000000..b3a482f
--- /dev/null
+++ b/queue-4.14/ftrace-avoid-potential-division-by-zero-in-function-profiler.patch
@@ -0,0 +1,49 @@
+From e31f7939c1c27faa5d0e3f14519eaf7c89e8a69d Mon Sep 17 00:00:00 2001
+From: Wen Yang <wenyang@linux.alibaba.com>
+Date: Fri, 3 Jan 2020 11:02:48 +0800
+Subject: ftrace: Avoid potential division by zero in function profiler
+
+From: Wen Yang <wenyang@linux.alibaba.com>
+
+commit e31f7939c1c27faa5d0e3f14519eaf7c89e8a69d upstream.
+
+The ftrace_profile->counter is unsigned long and
+do_div truncates it to 32 bits, which means it can test
+non-zero and be truncated to zero for division.
+Fix this issue by using div64_ul() instead.
+
+Link: http://lkml.kernel.org/r/20200103030248.14516-1-wenyang@linux.alibaba.com
+
+Cc: stable@vger.kernel.org
+Fixes: e330b3bcd8319 ("tracing: Show sample std dev in function profiling")
+Fixes: 34886c8bc590f ("tracing: add average time in function to function profiler")
+Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
+Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ kernel/trace/ftrace.c |    6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+--- a/kernel/trace/ftrace.c
++++ b/kernel/trace/ftrace.c
+@@ -622,8 +622,7 @@ static int function_stat_show(struct seq
+       }
+ 
+ #ifdef CONFIG_FUNCTION_GRAPH_TRACER
+-      avg = rec->time;
+-      do_div(avg, rec->counter);
++      avg = div64_ul(rec->time, rec->counter);
+       if (tracing_thresh && (avg < tracing_thresh))
+               goto out;
+ #endif
+@@ -649,7 +648,8 @@ static int function_stat_show(struct seq
+                * Divide only 1000 for ns^2 -> us^2 conversion.
+                * trace_print_graph_duration will divide 1000 again.
+                */
+-              do_div(stddev, rec->counter * (rec->counter - 1) * 1000);
++              stddev = div64_ul(stddev,
++                                rec->counter * (rec->counter - 1) * 1000);
+       }
+ 
+       trace_seq_init(&s);

diff --git a/queue-4.14/series b/queue-4.14/series
index 0e1c4f0549cf558c242ca5828ad36a89fc1cfd74..1f0e26c14c38d22893c9f82dc3d88bead4f58f72 100644 (file)
--- a/queue-4.14/series
+++ b/queue-4.14/series
@@ -41,3 +41,4 @@ tracing-have-the-histogram-compare-functions-convert-to-u64-first.patch
 alsa-cs4236-fix-error-return-comparison-of-an-unsigned-integer.patch
 alsa-firewire-motu-correct-a-typo-in-the-clock-proc-string.patch
 exit-panic-before-exit_mm-on-global-init-exit.patch
+ftrace-avoid-potential-division-by-zero-in-function-profiler.patch