regulator: s2dos05: fix OF node reference imbalance

The driver reuses the OF node of the parent multi-function device but
fails to take another reference to balance the one dropped by the
platform bus code when unbinding the MFD and deregistering the child
devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes: bb2441402392 ("regulator: add s2dos05 regulator support")
Cc: stable@vger.kernel.org	# 6.18
Cc: Dzmitry Sankouski <dsankouski@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260408073055.5183-6-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/regulator/s2dos05-regulator.c b/drivers/regulator/s2dos05-regulator.c
index 1463585c456520c69d5934b61b4bd195d5d39caf..a1c394ddbaff6e7e49cc5bedfa48ac5c7f767ceb 100644 (file)
--- a/drivers/regulator/s2dos05-regulator.c
+++ b/drivers/regulator/s2dos05-regulator.c
@@ -126,7 +126,7 @@ static int s2dos05_pmic_probe(struct platform_device *pdev)
        s2dos05->regmap = iodev->regmap_pmic;
        s2dos05->dev = dev;
        if (!dev->of_node)
-               dev->of_node = dev->parent->of_node;
+               device_set_of_node_from_dev(dev, dev->parent);
 
        config.dev = dev;
        config.driver_data = s2dos05;