]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
perf evsel: Missed close() when probing hybrid core PMUs
authorIan Rogers <irogers@google.com>
Sat, 14 Jun 2025 00:41:05 +0000 (17:41 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 17 Jun 2025 19:55:24 +0000 (16:55 -0300)
Add missing close() to avoid leaking perf events.

In past perfs this mattered little as the function was just used by 'perf
list'.

As the function is now used to detect hybrid PMUs leaking the perf event
is somewhat more painful.

Fixes: b41f1cec91c37eee ("perf list: Skip unsupported events")
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>
Link: https://lore.kernel.org/r/20250614004108.1650988-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/print-events.c

index a786cbfb0ff56a83d37dc70d0ab4c4f3787bdb00..83aaf7cda635909b882083029e439d45d0d486de 100644 (file)
@@ -268,6 +268,7 @@ bool is_event_supported(u8 type, u64 config)
                        ret = evsel__open(evsel, NULL, tmap) >= 0;
                }
 
+               evsel__close(evsel);
                evsel__delete(evsel);
        }