sched_ext: scx_cgroup_exit() may be called without successful scx_cgroup_init()

568894edbe48 ("sched_ext: Add scx_cgroup_enabled to gate cgroup operations
and fix scx_tg_online()") assumed that scx_cgroup_exit() is only called
after scx_cgroup_init() finished successfully. This isn't true.
scx_cgroup_exit() can be called without scx_cgroup_init() being called at
all or after scx_cgroup_init() failed in the middle.

As init state is tracked per cgroup, scx_cgroup_exit() can be used safely to
clean up in all cases. Remove the incorrect WARN_ON_ONCE().

Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 568894edbe48 ("sched_ext: Add scx_cgroup_enabled to gate cgroup operations and fix scx_tg_online()")

diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 76f04f3ace617ac6e2d5662ab7031b3d5253ff17..1df2082d1352e1794fce894a78f14722cadfcf3c 100644 (file)
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -4052,7 +4052,6 @@ static void scx_cgroup_exit(void)
 
        percpu_rwsem_assert_held(&scx_cgroup_rwsem);
 
-       WARN_ON_ONCE(!scx_cgroup_enabled);
        scx_cgroup_enabled = false;
 
        /*