]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-smtp: Remove double-assign of passthrough event
authorAki Tuomi <aki.tuomi@open-xchange.com>
Thu, 23 Jan 2020 08:33:17 +0000 (10:33 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Wed, 5 Feb 2020 12:10:32 +0000 (12:10 +0000)
Found by coverity

src/lib-smtp/smtp-server-recipient.c
src/lib-smtp/smtp-server-transaction.c

index 0c1dc7b1b0a923d19377baf11ad7afffdba7f188..43b32bf9a1df808308ada30ffbfe7d6518d44c69 100644 (file)
@@ -77,7 +77,7 @@ bool smtp_server_recipient_unref(struct smtp_server_recipient **_rcpt)
 
        if (!rcpt->finished) {
                struct event_passthrough *e =
-                       e = event_create_passthrough(rcpt->event)->
+                       event_create_passthrough(rcpt->event)->
                        set_name("smtp_server_transaction_rcpt_finished");
                e->add_int("status_code", 9000);
                e->add_str("enhanced_code", "9.0.0");
index e674fcbee987eddc094e137b972febf68ce51463..cebe7f76d84770888e47eb6c726e4c464858379d 100644 (file)
@@ -98,7 +98,7 @@ void smtp_server_transaction_free(struct smtp_server_transaction **_trans)
 
        if (!trans->finished) {
                struct event_passthrough *e =
-                       e = event_create_passthrough(trans->event)->
+                       event_create_passthrough(trans->event)->
                        set_name("smtp_server_transaction_finished")->
                        add_int("recipients", rcpts_total)->
                        add_int("recipients_denied", rcpts_failed)->