Bug 3447: assertion failed: CommCalls.h:150: "dp"

Detatch FD/connection close handlers from reliance on commCloseCbParams
some handlers use FdeCbParams and others are possible.

If the callback handler needs FD the call creator must save it in the
params at call construction time.

diff --git a/src/comm.cc b/src/comm.cc
index e69b5314b506dfc08f1c30ab726c9a77d6f371ea..908b10a141d9cc4f0d2b7f6d14af63695d74cdc2 100644 (file)
--- a/src/comm.cc
+++ b/src/comm.cc
@@ -937,10 +937,6 @@ commCallCloseHandlers(int fd)
         // If call is not canceled schedule it for execution else ignore it
         if (!call->canceled()) {
             debugs(5, 5, "commCallCloseHandlers: ch->handler=" << call);
-            // XXX: this should not be needed. Params can be set by the call creator
-            typedef CommCloseCbParams Params;
-            Params &params = GetCommParams<Params>(call);
-            params.fd = fd;
             ScheduleCallHere(call);
         }
     }