]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/i915: silence rpm wakeref asserts on GEN11_GU_MISC_IIR access
authorJani Nikula <jani.nikula@intel.com>
Tue, 5 Aug 2025 11:56:56 +0000 (14:56 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:34:36 +0000 (16:34 +0200)
commit ff646d033783068cc5b38924873cab4a536b17c1 upstream.

Commit 8d9908e8fe9c ("drm/i915/display: remove small micro-optimizations
in irq handling") not only removed the optimizations, it also enabled
wakeref asserts for the GEN11_GU_MISC_IIR access. Silence the asserts by
wrapping the access inside intel_display_rpm_assert_{block,unblock}().

Reported-by: "Jason A. Donenfeld" <Jason@zx2c4.com>
Closes: https://lore.kernel.org/r/aG0tWkfmxWtxl_xc@zx2c4.com
Fixes: 8d9908e8fe9c ("drm/i915/display: remove small micro-optimizations in irq handling")
Cc: stable@vger.kernel.org # v6.13+
Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Link: https://lore.kernel.org/r/20250805115656.832235-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
(cherry picked from commit cbd3baeffbc08052ce7dc53f11bf5524b4411056)
Signed-off-by: Tvrtko Ursulin <tursulin@ursulin.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/i915/display/intel_display_irq.c

index 3e73832e5e8132447fd5a5719dce4d489a547afe..9e785318a6e251f932e667393eb28d2802bec9eb 100644 (file)
@@ -1492,10 +1492,14 @@ u32 gen11_gu_misc_irq_ack(struct intel_display *display, const u32 master_ctl)
        if (!(master_ctl & GEN11_GU_MISC_IRQ))
                return 0;
 
+       intel_display_rpm_assert_block(display);
+
        iir = intel_de_read(display, GEN11_GU_MISC_IIR);
        if (likely(iir))
                intel_de_write(display, GEN11_GU_MISC_IIR, iir);
 
+       intel_display_rpm_assert_unblock(display);
+
        return iir;
 }