]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PM: freezer: Rewrite restarting tasks log to remove stray *done.*
authorPaul Menzel <pmenzel@molgen.mpg.de>
Sun, 11 May 2025 17:46:47 +0000 (19:46 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 16 May 2025 20:22:10 +0000 (22:22 +0200)
`pr_cont()` unfortunately does not work here, as other parts of the
Linux kernel log between the two log lines:

    [18445.295056] r8152-cfgselector 4-1.1.3: USB disconnect, device number 5
    [18445.295112] OOM killer enabled.
    [18445.295115] Restarting tasks ...
    [18445.295185] usb 3-1: USB disconnect, device number 2
    [18445.295193] usb 3-1.1: USB disconnect, device number 3
    [18445.296262] usb 3-1.5: USB disconnect, device number 4
    [18445.297017] done.
    [18445.297029] random: crng reseeded on system resumption

`pr_cont()` also uses the default log level, normally warning, if the
corresponding log line is interrupted.

Therefore, replace the `pr_cont()`, and explicitly log it as a separate
line with log level info:

    Restarting tasks: Starting
    […]
    Restarting tasks: Done

Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Link: https://patch.msgid.link/20250511174648.950430-1-pmenzel@molgen.mpg.de
[ rjw: Rebase on top of an earlier analogous change ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/power/process.c

index 4c674282df0313b434bd84c70f0658696af90d74..dc0dfc349f22b4505980cfd5d3bd9cff21475987 100644 (file)
@@ -189,7 +189,7 @@ void thaw_processes(void)
 
        oom_killer_enable();
 
-       pr_info("Restarting tasks ...\n");
+       pr_info("Restarting tasks: Starting\n");
 
        __usermodehelper_set_disable_depth(UMH_FREEZING);
        thaw_workqueues();
@@ -208,7 +208,7 @@ void thaw_processes(void)
        usermodehelper_enable();
 
        schedule();
-       pr_info("Done restarting tasks.\n");
+       pr_info("Restarting tasks: Done\n");
        trace_suspend_resume(TPS("thaw_processes"), 0, false);
 }