]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: dsa: remove dsa_port_phylink_mac_select_pcs()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 16 Oct 2024 09:58:24 +0000 (10:58 +0100)
committerAndrew Lunn <andrew@lunn.ch>
Thu, 17 Oct 2024 23:15:14 +0000 (18:15 -0500)
There is no longer any reason to implement the mac_select_pcs()
callback in DSA. Returning ERR_PTR(-EOPNOTSUPP) is functionally
equivalent to not providing the function.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
net/dsa/port.c

index f1e96706a7012b00f10372ebeab4f5e82f149cf9..ee0aaec4c8e0967c4c2a08e97a8d3270abd7525b 100644 (file)
@@ -1575,13 +1575,6 @@ void dsa_port_set_tag_protocol(struct dsa_port *cpu_dp,
        cpu_dp->tag_ops = tag_ops;
 }
 
-static struct phylink_pcs *
-dsa_port_phylink_mac_select_pcs(struct phylink_config *config,
-                               phy_interface_t interface)
-{
-       return ERR_PTR(-EOPNOTSUPP);
-}
-
 static void dsa_port_phylink_mac_config(struct phylink_config *config,
                                        unsigned int mode,
                                        const struct phylink_link_state *state)
@@ -1604,7 +1597,6 @@ static void dsa_port_phylink_mac_link_up(struct phylink_config *config,
 }
 
 static const struct phylink_mac_ops dsa_port_phylink_mac_ops = {
-       .mac_select_pcs = dsa_port_phylink_mac_select_pcs,
        .mac_config = dsa_port_phylink_mac_config,
        .mac_link_down = dsa_port_phylink_mac_link_down,
        .mac_link_up = dsa_port_phylink_mac_link_up,