device: remove nil elem check in finalizers

This is not necessary, and removing it speeds up detection of UAF bugs.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>

diff --git a/device/channels.go b/device/channels.go
index 1e3e2062339e48004ced71dc89ff9289ba431971..bf788682aeef1628dcd0d242906182e3a2d65314 100644 (file)
--- a/device/channels.go
+++ b/device/channels.go
@@ -87,9 +87,6 @@ func newAutodrainingInboundQueue(device *Device) *autodrainingInboundQueue {
                for {
                        select {
                        case elem := <-q.c:
-                               if elem == nil {
-                                       continue
-                               }
                                elem.Lock()
                                device.PutMessageBuffer(elem.buffer)
                                device.PutInboundElement(elem)
@@ -118,9 +115,6 @@ func newAutodrainingOutboundQueue(device *Device) *autodrainingOutboundQueue {
                for {
                        select {
                        case elem := <-q.c:
-                               if elem == nil {
-                                       continue
-                               }
                                elem.Lock()
                                device.PutMessageBuffer(elem.buffer)
                                device.PutOutboundElement(elem)