ata: libata-sata: Use BIT() macro to convert tag to bit field

The BIT() macro is commonly used in the kernel.
Make use of it when converting a tag, fetched from the Successful NCQ
Commands log or the NCQ Command Error log, to a bit field.
This makes the code easier to read.

Suggested-by: Igor Pylypiv <ipylypiv@google.com>
Signed-off-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Igor Pylypiv <ipylypiv@google.com>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>

diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
index 89d3b784706babe13e5f29249c3c69f5fbc4be94..4e3034af285e4943caf82517d65c8c542178cde2 100644 (file)
--- a/drivers/ata/libata-sata.c
+++ b/drivers/ata/libata-sata.c
@@ -1545,7 +1545,7 @@ int ata_eh_get_ncq_success_sense(struct ata_link *link)
                 * If the command does not have any sense data, clear ATA_SENSE.
                 * Keep ATA_QCFLAG_EH_SUCCESS_CMD so that command is finished.
                 */
-               if (!(sense_valid & (1 << tag))) {
+               if (!(sense_valid & BIT(tag))) {
                        qc->result_tf.status &= ~ATA_SENSE;
                        continue;
                }
@@ -1634,7 +1634,7 @@ void ata_eh_analyze_ncq_error(struct ata_link *link)
                return;
        }
 
-       if (!(link->sactive & (1 << tag))) {
+       if (!(link->sactive & BIT(tag))) {
                ata_link_err(link, "log page 10h reported inactive tag %d\n",
                             tag);
                return;