]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dm persistent data: remove unused return from exit_shadow_spine()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fri, 19 Mar 2021 08:19:30 +0000 (16:19 +0800)
committerMike Snitzer <snitzer@redhat.com>
Fri, 26 Mar 2021 18:53:42 +0000 (14:53 -0400)
Fix the following coccicheck warnings:

./drivers/md/persistent-data/dm-btree-spine.c:188:5-6: Unneeded
variable: "r". Return "0" on line 194.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/persistent-data/dm-btree-internal.h
drivers/md/persistent-data/dm-btree-spine.c

index fe073d92f01e66392f7bf7d20deef66541fe0200..d0c55916daa9a725cfda7c90bffb5775df15a6ac 100644 (file)
@@ -83,7 +83,7 @@ struct shadow_spine {
 };
 
 void init_shadow_spine(struct shadow_spine *s, struct dm_btree_info *info);
-int exit_shadow_spine(struct shadow_spine *s);
+void exit_shadow_spine(struct shadow_spine *s);
 
 int shadow_step(struct shadow_spine *s, dm_block_t b,
                struct dm_btree_value_type *vt);
index 8a2bfbfb218b4e7ca194a621564b082af68b6224..dd2ff3ca9bc65ba98ff5efc0b16590df04600572 100644 (file)
@@ -183,15 +183,13 @@ void init_shadow_spine(struct shadow_spine *s, struct dm_btree_info *info)
        s->count = 0;
 }
 
-int exit_shadow_spine(struct shadow_spine *s)
+void exit_shadow_spine(struct shadow_spine *s)
 {
-       int r = 0, i;
+       int i;
 
        for (i = 0; i < s->count; i++) {
                unlock_block(s->info, s->nodes[i]);
        }
-
-       return r;
 }
 
 int shadow_step(struct shadow_spine *s, dm_block_t b,