]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: stp-xway: Simplify using devm_clk_get_enabled()
authorRong Qianfeng <rongqianfeng@vivo.com>
Tue, 20 Aug 2024 12:16:50 +0000 (20:16 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 2 Sep 2024 10:31:48 +0000 (12:31 +0200)
Use devm_clk_get_enabled() simplify xway_stp_probe().

Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com>
Link: https://lore.kernel.org/r/20240820121651.29706-2-rongqianfeng@vivo.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-stp-xway.c

index 053d616f2e02a9eeddad85a92248a9f21d5a1cd7..5a6406d1f03aa75e82423f7c5740fdb3df42dd4b 100644 (file)
@@ -296,23 +296,17 @@ static int xway_stp_probe(struct platform_device *pdev)
        if (!of_property_read_bool(pdev->dev.of_node, "lantiq,rising"))
                chip->edge = XWAY_STP_FALLING;
 
-       clk = devm_clk_get(&pdev->dev, NULL);
+       clk = devm_clk_get_enabled(&pdev->dev, NULL);
        if (IS_ERR(clk)) {
                dev_err(&pdev->dev, "Failed to get clock\n");
                return PTR_ERR(clk);
        }
 
-       ret = clk_prepare_enable(clk);
-       if (ret)
-               return ret;
-
        xway_stp_hw_init(chip);
 
        ret = devm_gpiochip_add_data(&pdev->dev, &chip->gc, chip);
-       if (ret) {
-               clk_disable_unprepare(clk);
+       if (ret)
                return ret;
-       }
 
        dev_info(&pdev->dev, "Init done\n");