]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: intel/ipu6: Fix a null pointer dereference in ipu6_isys_query_stream_by_source
authorHao Ge <gehao@kylinos.cn>
Fri, 7 Jun 2024 08:25:42 +0000 (16:25 +0800)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 15 Jun 2024 09:51:23 +0000 (11:51 +0200)
stream is NULL when source is less than 0 in
ipu6_isys_query_stream_by_source. It's a null pointer dereference.

Actually, this should be isys->adev->auxdev.dev.

Fixes: 3c1dfb5a69cf ("media: intel/ipu6: input system video nodes and buffer queues")
Signed-off-by: Hao Ge <gehao@kylinos.cn>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/pci/intel/ipu6/ipu6-isys-video.c

index c8a33e1e910c918a6990ef3d2c61a6a8e30436a0..06090cc0a4760d53c2989e0077d65dfb76c7ec9d 100644 (file)
@@ -943,7 +943,7 @@ ipu6_isys_query_stream_by_source(struct ipu6_isys *isys, int source, u8 vc)
                return NULL;
 
        if (source < 0) {
-               dev_err(&stream->isys->adev->auxdev.dev,
+               dev_err(&isys->adev->auxdev.dev,
                        "query stream with invalid port number\n");
                return NULL;
        }