]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: sb: Don't allow changing the DMA mode during operations
authorTakashi Iwai <tiwai@suse.de>
Tue, 10 Jun 2025 06:43:19 +0000 (08:43 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 10 Jun 2025 06:45:33 +0000 (08:45 +0200)
When a PCM stream is already running, one shouldn't change the DMA
mode via kcontrol, which may screw up the hardware.  Return -EBUSY
instead.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=218185
Link: https://patch.msgid.link/20250610064322.26787-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/sb/sb16_main.c

index 74db115250030ed8679922205c568a46b5fd7145..c4930efd44e3a8e4d855290495cf7ecf69908aad 100644 (file)
@@ -703,6 +703,9 @@ static int snd_sb16_dma_control_put(struct snd_kcontrol *kcontrol, struct snd_ct
        unsigned char nval, oval;
        int change;
        
+       if (chip->mode & (SB_MODE_PLAYBACK | SB_MODE_CAPTURE))
+               return -EBUSY;
+
        nval = ucontrol->value.enumerated.item[0];
        if (nval > 2)
                return -EINVAL;