Fix memory leak due to LogicalRepRelMapEntry.attrmap.

When rebuilding the relation mapping on subscribers, we were not releasing
the attribute mapping's memory which was no longer required.

The attribute mapping used in logical tuple conversion was refactored in
PG13 (by commit e1551f96e6) but we forgot to update the related code that
frees the attribute map.

Author: Hou Zhijie
Reviewed-by: Amit Langote, Amit Kapila, Shi yu
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com

diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c
index d1ea5c3385d9e3b24bd87e884c1d4206996ebda2..77f1d412e87ee1260a14a50c83a65055da77bb8a 100644 (file)
--- a/src/backend/replication/logical/relation.c
+++ b/src/backend/replication/logical/relation.c
@@ -259,6 +259,13 @@ logicalrep_rel_open(LogicalRepRelId remoteid, LOCKMODE lockmode)
                MemoryContext oldctx;
                int                     i;
 
+               /* Release the no-longer-useful attrmap, if any. */
+               if (entry->attrmap)
+               {
+                       pfree(entry->attrmap);
+                       entry->attrmap = NULL;
+               }
+
                /* Try to find and lock the relation by name. */
                relid = RangeVarGetRelid(makeRangeVar(remoterel->nspname,
                                                                                          remoterel->relname, -1),