]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: iwlwifi: Fix memory leak in iwl_mvm_init()
authorXiu Jianfeng <xiujianfeng@huawei.com>
Wed, 9 Nov 2022 03:52:13 +0000 (11:52 +0800)
committerMiri Korenblit <miriam.rachel.korenblit@intel.com>
Wed, 25 Jun 2025 07:57:34 +0000 (10:57 +0300)
When iwl_opmode_register() fails, it does not unregster rate control,
which will cause a memory leak issue, this patch fixes it.

Fixes: 9f66a397c877 ("iwlwifi: mvm: rs: add ops for the new rate scaling in the FW")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Link: https://patch.msgid.link/20221109035213.570-1-xiujianfeng@huawei.com
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/ops.c

index a2dc5c3b0596dbff5f8b1e120bc0aebc3fcd7ad3..1c05a3d8e4245f80868e1391faa187d40d21d8c8 100644 (file)
@@ -61,8 +61,10 @@ static int __init iwl_mvm_init(void)
        }
 
        ret = iwl_opmode_register("iwlmvm", &iwl_mvm_ops);
-       if (ret)
+       if (ret) {
                pr_err("Unable to register MVM op_mode: %d\n", ret);
+               iwl_mvm_rate_control_unregister();
+       }
 
        return ret;
 }