]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Revert "drm/i915/gem: Allow EXEC_CAPTURE on recoverable contexts on DG1"
authorJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Thu, 22 May 2025 06:41:27 +0000 (09:41 +0300)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Tue, 27 May 2025 13:40:55 +0000 (16:40 +0300)
This reverts commit d6e020819612a4a06207af858e0978be4d3e3140.

The IS_DGFX check was put in place because error capture of buffer
objects is expected to be broken on devices with VRAM.

Userspace fix[1] to the impacted media driver has been submitted, merged
and a new driver release is out as 25.2.3 where the capture flag is
dropped on DG1 thus unblocking the usage of media driver on DG1.

[1] https://github.com/intel/media-driver/commit/93c07d9b4b96a78bab21f6acd4eb863f4313ea4a

Cc: stable@vger.kernel.org # v6.0+
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Tvrtko Ursulin <tursulin@ursulin.net>
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://lore.kernel.org/r/20250522064127.24293-1-joonas.lahtinen@linux.intel.com
[Joonas: Update message to point out the merged userspace fix]
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
(cherry picked from commit d2dc30e0aa252830f908c8e793d3139d51321370)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c

index ea9d5063ce78c711487f216fce2b0b61f904443a..ca7e9216934a7d89f9f2b5ab3bfa445b75cffc84 100644 (file)
@@ -2013,7 +2013,7 @@ static int eb_capture_stage(struct i915_execbuffer *eb)
                        continue;
 
                if (i915_gem_context_is_recoverable(eb->gem_context) &&
-                   GRAPHICS_VER_FULL(eb->i915) > IP_VER(12, 10))
+                   (IS_DGFX(eb->i915) || GRAPHICS_VER_FULL(eb->i915) > IP_VER(12, 0)))
                        return -EINVAL;
 
                for_each_batch_create_order(eb, j) {