]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: brcmstb: Assign pcie->gen from of_pci_get_max_link_speed()
authorFlorian Fainelli <florian.fainelli@broadcom.com>
Wed, 6 May 2026 16:45:37 +0000 (09:45 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 15 May 2026 18:09:52 +0000 (13:09 -0500)
After commit 03f920936977 ("PCI: controller: Validate max-link-speed"),
pcie->gen stopped being assigned and as a result the established PCIe link
would stop supporting Gen3 speeds on 2712 since pcie->gen is used to
populate LnkCntl2 and LnkCap in brcm_pcie_set_gen().

If the 'max-link-speed' property is not specified, or it exceeds Gen3,
resort to the HW defaults.

Link: https://github.com/raspberrypi/linux/issues/7343
Reported-by: Dom Cobley <popcornmix@gmail.com>
Reported-by: Phil Elwell <phil@raspberrypi.com>
Fixes: 03f920936977 ("PCI: controller: Validate max-link-speed")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Hans Zhang <18255117159@163.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/20260506164537.103196-1-florian.fainelli@broadcom.com
drivers/pci/controller/pcie-brcmstb.c

index 714bcab97b603f8065f7c765f3e37fbdc0404f03..08a0e7091cedcac355be44ab08db1478ebd85b99 100644 (file)
@@ -2072,8 +2072,10 @@ static int brcm_pcie_probe(struct platform_device *pdev)
                return PTR_ERR(pcie->clk);
 
        ret = of_pci_get_max_link_speed(np);
-       if (pcie_get_link_speed(ret) == PCI_SPEED_UNKNOWN)
+       if (ret < 0 || ret > 3)
                pcie->gen = 0;
+       else
+               pcie->gen = ret;
 
        pcie->ssc = of_property_read_bool(np, "brcm,enable-ssc");