]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Bluetooth: btnxpuart: Fix missing devm_request_irq() return value check
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sun, 25 May 2025 19:00:21 +0000 (21:00 +0200)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 30 May 2025 17:29:34 +0000 (13:29 -0400)
Return value of devm_request_irq() must be checked (function is even
annotated) and without it clang W=1 complains:

  btnxpuart.c:494:6: error: unused variable 'ret' [-Werror,-Wunused-variable]

Setting up wakeup IRQ handler is not really critical, because the
handler is empty, so just log the informational message so user could
submit proper bug report and silences the clang warning.

Fixes: c50b56664e48 ("Bluetooth: btnxpuart: Implement host-wakeup feature")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/btnxpuart.c

index b34623a69b8ae976645f619c3c843962a9311284..6b13feed06df4e10aaa8cda4744efe53261454e1 100644 (file)
@@ -533,6 +533,8 @@ static int ps_setup(struct hci_dev *hdev)
                                        ps_host_wakeup_irq_handler,
                                        IRQF_ONESHOT | IRQF_TRIGGER_FALLING,
                                        dev_name(&serdev->dev), nxpdev);
+               if (ret)
+                       bt_dev_info(hdev, "error setting wakeup IRQ handler, ignoring\n");
                disable_irq(psdata->irq_handler);
                device_init_wakeup(&serdev->dev, true);
        }