]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mmc: renesas_sdhi: fix error code in renesas_sdhi_probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 14 Mar 2025 10:11:09 +0000 (13:11 +0300)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 19 Mar 2025 11:34:11 +0000 (12:34 +0100)
If devm_regulator_register() fails then propagate the error code.  Don't
return success.

Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/dc39e555-8ef7-4a39-9253-65bcf3e50c01@stanley.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/renesas_sdhi_core.c

index 396fa2816a154deb28e5cdc0c62a3fa1a75c4582..fa6526be36381dea7077280e1c27d552a09254bb 100644 (file)
@@ -1178,6 +1178,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
                of_node_put(rcfg.of_node);
                if (IS_ERR(rdev)) {
                        dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev));
+                       ret = PTR_ERR(rdev);
                        goto efree;
                }
                priv->rdev = rdev;