]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
aarch64: Fix early ra for -fno-delete-dead-exceptions [PR116927]
authorAndrew Pinski <quic_apinski@quicinc.com>
Wed, 2 Oct 2024 21:21:24 +0000 (14:21 -0700)
committerAndrew Pinski <quic_apinski@quicinc.com>
Thu, 3 Oct 2024 08:31:11 +0000 (01:31 -0700)
Early-RA was considering throwing instructions as being dead and removing
them even if -fno-delete-dead-exceptions was in use. This fixes that oversight.

Built and tested for aarch64-linux-gnu.

PR target/116927

gcc/ChangeLog:

* config/aarch64/aarch64-early-ra.cc (early_ra::is_dead_insn): Insns
that throw are not dead with -fno-delete-dead-exceptions.

gcc/testsuite/ChangeLog:

* g++.dg/torture/pr116927-1.C: New test.

Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
gcc/config/aarch64/aarch64-early-ra.cc
gcc/testsuite/g++.dg/torture/pr116927-1.C [new file with mode: 0644]

index 5f269d029b45704776968815eaeedd51426f48e0..6e544dd619150aa9997fb73407c2fa030a284d39 100644 (file)
@@ -3389,6 +3389,12 @@ early_ra::is_dead_insn (rtx_insn *insn)
   if (side_effects_p (set))
     return false;
 
+  /* If we can't delete dead exceptions and the insn throws,
+     then the instruction is not dead.  */
+  if (!cfun->can_delete_dead_exceptions
+      && !insn_nothrow_p (insn))
+    return false;
+
   return true;
 }
 
diff --git a/gcc/testsuite/g++.dg/torture/pr116927-1.C b/gcc/testsuite/g++.dg/torture/pr116927-1.C
new file mode 100644 (file)
index 0000000..22fa1db
--- /dev/null
@@ -0,0 +1,15 @@
+// { dg-do compile }
+// { dg-additional-options "-fnon-call-exceptions -fno-delete-dead-exceptions" }
+
+// PR target/116927
+// aarch64's Early ra was removing possiblely trapping
+// floating point insn
+
+void
+foo (float f)
+{
+  try {
+    f ++;
+  }catch(...)
+  {}
+}