lib: file_create_locked() - Unexpectedly deleted temp file is error.

This shouldn't happen and we shouldn't be silently retrying if it does.

diff --git a/src/lib/file-create-locked.c b/src/lib/file-create-locked.c
index 3ea4c66b70359ab9dbaf4b3200e53cc86afc7730..905e8cdc01f583df92097cca91a4d2add5695bc8 100644 (file)
--- a/src/lib/file-create-locked.c
+++ b/src/lib/file-create-locked.c
@@ -69,9 +69,11 @@ try_create_new(const char *path, const struct file_create_settings *set,
                        /* just created by somebody else */
                        ret = 0;
                } else if (errno == ENOENT) {
-                       /* our temp file was just deleted by somebody else,
-                          retry creating it. */
-                       ret = 0;
+                       /* nobody should be deleting the temp file unless the
+                          entire directory is deleted. */
+                       *error_r = t_strdup_printf(
+                               "Temporary file %s was unexpectedly deleted",
+                               str_c(temp_path));
                } else {
                        *error_r = t_strdup_printf("link(%s, %s) failed: %m",
                                                   str_c(temp_path), path);