Author: Philippe Lantin <plantin@cobaltgroup.com>

Bug #2624: Invalid response for IMS request

Squid forgot to verify the client provided If-Modified-Since when
seeing a 304 from upstream.

diff --git a/src/client_side_reply.cc b/src/client_side_reply.cc
index 383d9b9a105cf309d94f35bcc4b359000e883d20..e9a1d0cad982360fa32ae04a357b3f733cc53702 100644 (file)
--- a/src/client_side_reply.cc
+++ b/src/client_side_reply.cc
@@ -368,7 +368,7 @@ clientReplyContext::handleIMSReply(StoreIOBuffer result)
 
         // if client sent IMS
 
-        if (http->request->flags.ims) {
+        if (http->request->flags.ims && !old_entry->modifiedSince(http->request)) {
             // forward the 304 from origin
             debugs(88, 3, "handleIMSReply: origin replied 304, revalidating existing entry and forwarding 304 to client");
             sendClientUpstreamResponse();