]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm: adp: Fix NULL vs IS_ERR() check in adp_plane_new()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 7 Mar 2025 09:30:58 +0000 (12:30 +0300)
committerAlyssa Rosenzweig <alyssa@rosenzweig.io>
Fri, 14 Mar 2025 13:42:11 +0000 (09:42 -0400)
The __drmm_universal_plane_alloc() function doesn't return NULL, it
returns error pointers.  Update the check to match.

Fixes: 332122eba628 ("drm: adp: Add Apple Display Pipe driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/14a845e8-54d0-45f8-b8b9-927609d92ede@stanley.mountain
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
drivers/gpu/drm/adp/adp_drv.c

index 0eeb9e5fab26638bb4ff0110567e51145b533b4e..c98c647f981d5383149647126762a5cdec8f4e4b 100644 (file)
@@ -232,9 +232,9 @@ static struct drm_plane *adp_plane_new(struct adp_drv_private *adp)
                                             ALL_CRTCS, &adp_plane_funcs,
                                             plane_formats, ARRAY_SIZE(plane_formats),
                                             NULL, DRM_PLANE_TYPE_PRIMARY, "plane");
-       if (!plane) {
+       if (IS_ERR(plane)) {
                drm_err(drm, "failed to allocate plane");
-               return ERR_PTR(-ENOMEM);
+               return plane;
        }
 
        drm_plane_helper_add(plane, &adp_plane_helper_funcs);