]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
cmd: tlv_eeprom: improve mac_read_from_eeprom() log messages
authorHugo Villeneuve <hvilleneuve@dimonoff.com>
Wed, 18 Jun 2025 13:25:37 +0000 (09:25 -0400)
committerStefan Roese <stefan.roese@mailbox.org>
Tue, 29 Jul 2025 06:44:18 +0000 (08:44 +0200)
mac_read_from_eeprom() always display debug infos, and this messes up the
display of the "Net:" section details:

Before:
    Net:   EEPROM: TlvInfo v1 len=172
    eth0: ethernet@11c20000

After:
    Net:   eth0: ethernet@11c20000

Fix by moving unconditional "EEPROM: " header into each message and
changing debug message to use log_debug().

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
cmd/tlv_eeprom.c

index 89546cef16fd2315fab25eb1c02bb8e89af5a035..3127660dd9e055c500c827955a93e452c9d89a5f 100644 (file)
@@ -1033,10 +1033,8 @@ int mac_read_from_eeprom(void)
        struct tlvinfo_header *eeprom_hdr = to_header(eeprom);
        int devnum = 0; // TODO: support multiple EEPROMs
 
-       puts("EEPROM: ");
-
        if (read_eeprom(devnum, eeprom)) {
-               printf("Read failed.\n");
+               log_err("EEPROM: read failed\n");
                return -1;
        }
 
@@ -1082,8 +1080,8 @@ int mac_read_from_eeprom(void)
                }
        }
 
-       printf("%s v%u len=%u\n", eeprom_hdr->signature, eeprom_hdr->version,
-              be16_to_cpu(eeprom_hdr->totallen));
+       log_debug("EEPROM: %s v%u len=%u\n", eeprom_hdr->signature, eeprom_hdr->version,
+                 be16_to_cpu(eeprom_hdr->totallen));
 
        return 0;
 }