iptables: Coverity: REVERSE_INULL

ip6tables-restore.c:186: deref_ptr_in_call: Dereferencing pointer "in".
ip6tables-restore.c:463: check_after_deref: Dereferencing "in"
before a null check.
iptables-restore.c:192: deref_ptr_in_call: Dereferencing pointer "in".
iptables-restore.c:468: check_after_deref: Dereferencing "in" before a
null check.
iptables-xml.c:671: deref_ptr_in_call: Dereferencing pointer "in".
iptables-xml.c:873: check_after_deref: Dereferencing "in" before a
null check.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>

diff --git a/iptables/ip6tables-restore.c b/iptables/ip6tables-restore.c
index 420bc523038b1c49765d08460fd5a84248b4e59a..ae147d55473cd75dc072c3b833687ec819b06475 100644 (file)
--- a/iptables/ip6tables-restore.c
+++ b/iptables/ip6tables-restore.c
@@ -460,7 +460,6 @@ int main(int argc, char *argv[])
                exit(1);
        }
 
-       if (in != NULL)
-               fclose(in);
+       fclose(in);
        return 0;
 }

diff --git a/iptables/iptables-restore.c b/iptables/iptables-restore.c
index 2624599773a265415a2c0e2e4831f304a946c0dd..1cb833c0fdf3b895b2ac856ce4cce1dc74f1bf8b 100644 (file)
--- a/iptables/iptables-restore.c
+++ b/iptables/iptables-restore.c
@@ -465,7 +465,6 @@ main(int argc, char *argv[])
                exit(1);
        }
 
-       if (in != NULL)
-               fclose(in);
+       fclose(in);
        return 0;
 }

diff --git a/iptables/iptables-xml.c b/iptables/iptables-xml.c
index 5aa638c01ec13a9e7303750ea9eecf8861dd3ff5..502b2d96244af9852c946de2edbb6e9098145c00 100644 (file)
--- a/iptables/iptables-xml.c
+++ b/iptables/iptables-xml.c
@@ -865,8 +865,7 @@ main(int argc, char *argv[])
                exit(1);
        }
 
-       if (in != NULL)
-               fclose(in);
+       fclose(in);
        printf("</iptables-rules>\n");
        free_argv();