]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
thermal: core: Drop need_update field from struct thermal_zone_device
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 4 Oct 2024 19:35:16 +0000 (21:35 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 22 Oct 2024 10:07:54 +0000 (12:07 +0200)
After previous changes, the need_update field in struct thermal_zone_device
is only set and never read, so drop it.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2495061.jE0xQCEvom@rjwysocki.net
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
drivers/thermal/thermal_core.c
drivers/thermal/thermal_core.h

index b8c3a9185ae72727046420dd8ed87a4aedab5794..13e22fcfad184fba12767e145ce11c932859ca68 100644 (file)
@@ -842,7 +842,6 @@ static int thermal_bind_cdev_to_trip(struct thermal_zone_device *tz,
        if (!result) {
                list_add_tail(&dev->tz_node, &tz->thermal_instances);
                list_add_tail(&dev->cdev_node, &cdev->thermal_instances);
-               atomic_set(&tz->need_update, 1);
 
                thermal_governor_update_tz(tz, THERMAL_TZ_BIND_CDEV);
        }
@@ -1507,9 +1506,6 @@ thermal_zone_device_register_with_trips(const char *type,
        if (result)
                goto remove_id;
 
-       /* A new thermal zone needs to be updated anyway. */
-       atomic_set(&tz->need_update, 1);
-
        result = dev_set_name(&tz->device, "thermal_zone%d", tz->id);
        if (result) {
                thermal_zone_destroy_device_groups(tz);
index f8d2e85d24081735bd324b12db80390cfde04d5e..a28f7198f91761a13e8f73319e5860033fc05b48 100644 (file)
@@ -96,7 +96,6 @@ struct thermal_governor {
                        trip point.
  * @prev_high_trip:    the above current temperature if you've crossed a
                        passive trip point.
- * @need_update:       if equals 1, thermal_zone_device_update needs to be invoked.
  * @ops:       operations this &thermal_zone_device supports
  * @tzp:       thermal zone parameters
  * @governor:  pointer to the governor for this thermal zone
@@ -130,7 +129,6 @@ struct thermal_zone_device {
        int passive;
        int prev_low_trip;
        int prev_high_trip;
-       atomic_t need_update;
        struct thermal_zone_device_ops ops;
        struct thermal_zone_params *tzp;
        struct thermal_governor *governor;