]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: dlink: fix multicast stats being counted incorrectly
authorYeounsu Moon <yyyynoom@gmail.com>
Sat, 23 Aug 2025 18:29:24 +0000 (03:29 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Sep 2025 13:31:48 +0000 (15:31 +0200)
[ Upstream commit 007a5ffadc4fd51739527f1503b7cf048f31c413 ]

`McstFramesRcvdOk` counts the number of received multicast packets, and
it reports the value correctly.

However, reading `McstFramesRcvdOk` clears the register to zero. As a
result, the driver was reporting only the packets since the last read,
instead of the accumulated total.

Fix this by updating the multicast statistics accumulatively instaed of
instantaneously.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Tested-on: D-Link DGE-550T Rev-A3
Signed-off-by: Yeounsu Moon <yyyynoom@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250823182927.6063-3-yyyynoom@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/dlink/dl2k.c

index 787218d60c6b16402c66953865e06997140d7faa..2c1b551e14423145f705e55afdfaea2c1b0a7159 100644 (file)
@@ -1091,7 +1091,7 @@ get_stats (struct net_device *dev)
        dev->stats.rx_bytes += dr32(OctetRcvOk);
        dev->stats.tx_bytes += dr32(OctetXmtOk);
 
-       dev->stats.multicast = dr32(McstFramesRcvdOk);
+       dev->stats.multicast += dr32(McstFramesRcvdOk);
        dev->stats.collisions += dr32(SingleColFrames)
                             +  dr32(MultiColFrames);