Review comments Matthijs.

git-svn-id: file:///svn/unbound/tags/release-1.3.0@1638 be551aaa-1e26-0410-a405-d3ace91eadb9

diff --git a/doc/Changelog b/doc/Changelog
index 287a583f8d4cc48536807d22e83923b6c65aaf39..33179f773d73ee2cae3e2c5a05458db2db306310 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,6 +1,7 @@
 3 June 2009: Wouter
        - fixup bad free() when wrongly encoded DSA signature is seen.
          Reported by Paul Wouters.
+       - review comments from Matthijs.
 
 2 June 2009: Wouter
        - --enable-sha2 option. The draft rsasha256 changed its algorithm

diff --git a/iterator/iterator.c b/iterator/iterator.c
index 5e6dc5e17bee46e027ad1129d64cbf367a2a8b4b..72d5198ebef7e6e8bbc03d81528c1c3f72e1d8e3 100644 (file)
--- a/iterator/iterator.c
+++ b/iterator/iterator.c
@@ -1771,8 +1771,10 @@ processTargetResponse(struct module_qstate* qstate, int id,
        log_query_info(VERB_ALGO, "processTargetResponse super", &forq->qinfo);
 
        /* check to see if parent event is still interested (in orig name).  */
-       if(!foriq->dp)
+       if(!foriq->dp) {
+               verbose(VERB_ALGO, "subq: parent not interested, was reset");
                return; /* not interested anymore */
+       }
        dpns = delegpt_find_ns(foriq->dp, qstate->qinfo.qname,
                        qstate->qinfo.qname_len);
        if(!dpns) {

diff --git a/services/listen_dnsport.c b/services/listen_dnsport.c
index f0bec69a7d15fe5885878b4534377b1c87659701..c6079008c198e4b3db00d706a667709c5b8d3e4d 100644 (file)
--- a/services/listen_dnsport.c
+++ b/services/listen_dnsport.c
@@ -176,7 +176,7 @@ create_udp_sock(int family, int socktype, struct sockaddr* addr,
                        *noproto = 1;
                else if(errno != EADDRINUSE)
                        log_err("can't bind socket: %s", strerror(errno));
-#endif
+#endif /* EADDRINUSE */
                close(s);
 #else /* USE_WINSOCK */
                if(WSAGetLastError() != WSAEADDRINUSE &&