]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
PCI: qcom-ep: Remove redundant edma.nr_irqs initialization
authorNiklas Cassel <cassel@kernel.org>
Mon, 8 Sep 2025 16:59:16 +0000 (18:59 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 12 Sep 2025 21:54:14 +0000 (16:54 -0500)
dw_pcie_edma_irq_verify() already parses device tree for either "dma" (if
there is a single IRQ for all DMA channels) or "dmaX" (if there is one IRQ
per DMA channel), and initializes dma.nr_irqs accordingly.

Additionally, the probing of the eDMA driver will fail if neither "dma"
nor "dmaX" is defined in the device tree.

Therefore there is no need for a glue driver to specify edma.nr_irqs, so
remove the redundant edma.nr_irqs initialization.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
[bhelgaas: fix typos]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20250908165914.547002-4-cassel@kernel.org
drivers/pci/controller/dwc/pcie-qcom-ep.c

index bf7c6ac0f3e3962de8346ab6e75dfff1d9642aad..ad98598bb52289fecc59b4228333d17725d15f46 100644 (file)
@@ -874,7 +874,6 @@ static int qcom_pcie_ep_probe(struct platform_device *pdev)
        pcie_ep->pci.dev = dev;
        pcie_ep->pci.ops = &pci_ops;
        pcie_ep->pci.ep.ops = &pci_ep_ops;
-       pcie_ep->pci.edma.nr_irqs = 1;
 
        pcie_ep->cfg = of_device_get_match_data(dev);
        if (pcie_ep->cfg && pcie_ep->cfg->hdma_support) {