Fix memory leak in refresh_pattern parsing

Occurs when refresh_pattern is configure with invalid regex pattern.

 Detected by Coverity Scan. Issue 1058882.

diff --git a/src/cache_cf.cc b/src/cache_cf.cc
index 521c9dd5f596cb6b949d973532503c2656b99ab0..885008db17fea993ca09d4f358b42a5b5b25a430 100644 (file)
--- a/src/cache_cf.cc
+++ b/src/cache_cf.cc
@@ -2899,6 +2899,7 @@ parse_refreshpattern(RefreshPattern ** head)
         regerror(errcode, &comp, errbuf, sizeof errbuf);
         debugs(22, DBG_CRITICAL, "" << cfg_filename << " line " << config_lineno << ": " << config_input_line);
         debugs(22, DBG_CRITICAL, "refreshAddToList: Invalid regular expression '" << pattern << "': " << errbuf);
+        xfree(pattern);
         return;
     }